Fix older podcasts not loading due to feed cache cap (#174)#175
Merged
Conversation
Older episodes were hidden because the 75-episode disk cache was reused when opening a show or the Played view. Fetch the full RSS feed for those actions while keeping the cache for background Latest Episodes aggregation.
Deploying podnotes with
|
| Latest commit: |
d1476bf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dab65956.podnotes.pages.dev |
| Branch Preview URL: | https://chhoumann-shanghai.podnotes.pages.dev |
Skip only the truncated disk cache on show and Played view opens. After a full RSS fetch, reuse the in-memory feed until refresh forces a network reload.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e111a2e825
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Fall back to in-memory or persisted episodes when a forced network fetch fails, and limit Played view fetches to feeds that actually have finished played episodes.
chhoumann
force-pushed
the
chhoumann/shanghai
branch
from
e4e9719 to
d1476bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #174 by fetching the full RSS feed when a user opens a show or the Played view, instead of reusing the 75-episode disk cache introduced in #124. Background Latest Episodes aggregation still uses the truncated cache for fast startup. Adds regression tests that reproduce the truncated-cache scenario and a unit test documenting the 75-episode persist cap.
Test plan
npm test— 152 tests passMade with Cursor